Add metrics reader interface and gen proto #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <[email protected]>
14 tasks
Codecov Report
@@ Coverage Diff @@
## master #2977 +/- ##
==========================================
+ Coverage 95.90% 95.96% +0.06%
==========================================
Files 223 223
Lines 9720 9720
==========================================
+ Hits 9322 9328 +6
+ Misses 328 324 -4
+ Partials 70 68 -2
Continue to review full report at Codecov.
|
yurishkuro
reviewed
May 4, 2021
proto-gen/api_v2/service.pb.go
Outdated
| @@ -0,0 +1,2062 @@ | |||
| // Code generated by protoc-gen-gogo. DO NOT EDIT. | |||
There was a problem hiding this comment.
yeah, I'd originally tried query.proto but protoc complains about filenames shadowing one another with the existing query.proto, which is why I chose service.proto but agree it could be better named.
I've gone with metricsquery.proto. Let me know if you prefer another name.
storage/metricsstore/interface.go
Outdated
| "context" | ||
| "time" | ||
|
|
||
| "github.com/jaegertracing/jaeger/proto-gen/api_v2" |
There was a problem hiding this comment.
perhaps we should move the gen-types under api_v2/metrics?
Signed-off-by: albertteoh <[email protected]>
Signed-off-by: albertteoh <[email protected]>
yurishkuro
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: albertteoh [email protected]
Which problem is this PR solving?
Short description of the changes