[abandoned][es] Add index rollover mode that can choose day and hour

[WalkerWang731]

Which problem is this PR solving?

• Resolves ES index rotation mode can choice with day and hour #2933
• Replace [abandoned][es] Add index rollover mode that can choose day and hour #2935

Short description of the changes

• Add a parameter index-rollover-frequency, default is day mode, will not affect existing usage
• Minimize changes to ensure compatibility with previous code

Parameter config of collector ingester query (SPAN_STORAGE_TYPE=elasticsearch)

--es-archive.index-rollover-frequency string                     Rotates Jaeger indices over the given period. For example "day" creates "jaeger-span-yyyy-HH-dd" every day after UTC 12AM. Valid options: [hour, day]. Jaeger also support Elasticsearch ILM to manage indices, reference(https://www.jaegertracing.io/docs/deployment/#elasticsearch-ilm-support) (default "day")
--es.index-rollover-frequency string                             Rotates Jaeger indices over the given period. For example "day" creates "jaeger-span-yyyy-HH-dd" every day after UTC 12AM. Valid options: [hour, day]. Jaeger also support Elasticsearch ILM to manage indices, reference(https://www.jaegertracing.io/docs/deployment/#elasticsearch-ilm-support) (default "day")

[codecov]

Codecov Report

Merging #2962 (74c1a30) into master (312f83b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
- Coverage   95.95%   95.91%   -0.04%     
==========================================
  Files         223      223              
  Lines        9712     9726      +14     
==========================================
+ Hits         9319     9329      +10     
- Misses        324      328       +4     
  Partials       69       69              

Impacted Files	Coverage Δ
plugin/storage/es/options.go	100.00% <100.00%> (ø)
plugin/storage/es/spanstore/reader.go	100.00% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go	92.20% <0.00%> (-2.60%)	⬇️
...lugin/sampling/strategystore/adaptive/processor.go	99.07% <0.00%> (-0.93%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312f83b...74c1a30. Read the comment docs.

[WalkerWang731]

Hi @albertteoh
Sorry for the trouble with you. I have recreated a new PR that repair the signoff issue (here), let us discuss on here

[yurishkuro]

please do not create PRs from master branch of your fork (this is the reason CI is failing). Always use a named branch.

[WalkerWang731]

please do not create PRs from master branch of your fork (this is the reason CI is failing). Always use a named branch.

ok, I see, thank you!
I recreate a new PR for replacement this, let us switch to that.