-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Increase timeout for TestGRPCResolverRoundRobin #2729
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
ha, interesting, the logging already yielded fruit, the test failed like this:
Because it's the very first connection that failed, it can only be due to timing, as there are no other conditions. Also, first connections in the subsequent tests are often acquired after 2-3 hundred iterations, almost half of the total time, e.g. this one at 400:
Even though we have a pretty long timeout already (1000 * 10ms = 10s), I am going to increase it even more. |
Codecov Report
@@ Coverage Diff @@
## master #2729 +/- ##
==========================================
+ Coverage 95.73% 95.75% +0.01%
==========================================
Files 216 217 +1
Lines 9599 9619 +20
==========================================
+ Hits 9190 9211 +21
Misses 336 336
+ Partials 73 72 -1
Continue to review full report at Codecov.
|
@@ -84,19 +84,20 @@ func makeSureConnectionsUp(t *testing.T, count int, testc grpctest.TestServiceCl | |||
// Make sure connections to all servers are up. | |||
for si := 0; si < count; si++ { | |||
connected := false | |||
for i := 0; i < 1000; i++ { | |||
for i := 0; i < 3000; i++ { // 3000 * 10ms = 30s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the main change/fix
…g#2729) * [tests] Add logging for TestGRPCResolverRoundRobin Signed-off-by: Yuri Shkuro <[email protected]> * rename var for clarity Signed-off-by: Yuri Shkuro <[email protected]> * cleanup Signed-off-by: Yuri Shkuro <[email protected]> * increase timeout Signed-off-by: Yuri Shkuro <[email protected]>
Resolves #2025.
At first this was just adding extra logging, but per the next comment the logging indicated that it's indeed a timing issue.
Also did some clean-up of the code, like pre-allocating arrays with the right sizes.