Add support for Kafka SASL/PLAIN authentication via SCRAM-SHA-256 or SCRAM-SHA-512 mechanism #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CRAM-SHA-512 mechanism Signed-off-by: WalkerWang731 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2724 +/- ##
==========================================
+ Coverage 95.73% 95.76% +0.03%
==========================================
Files 217 217
Lines 9619 9619
==========================================
+ Hits 9209 9212 +3
+ Misses 337 336 -1
+ Partials 73 71 -2
Continue to review full report at Codecov.
|
jpkrohling
reviewed
Jan 12, 2021
yurishkuro
reviewed
Jan 12, 2021
…nt on factory_test.go Signed-off-by: WalkerWang731 <[email protected]>
jpkrohling
reviewed
Jan 13, 2021
pkg/kafka/auth/plaintext.go
Outdated
| // PlainTextConfig describes the configuration properties needed for SASL/PLAIN with kafka | ||
| type PlainTextConfig struct { | ||
| UserName string `mapstructure:"username"` | ||
| Password string `mapstructure:"password" json:"-"` | ||
| UserName string `mapstructure:"username"` |
There was a problem hiding this comment.
Suggested change
| UserName string `mapstructure:"username"` | |
| Username string `mapstructure:"username"` |
There was a problem hiding this comment.
ok, I will update later.
Signed-off-by: WalkerWang731 <[email protected]>
Signed-off-by: WalkerWang731 <[email protected]>
yurishkuro
approved these changes
Jan 14, 2021
yurishkuro
changed the title
bhiravabhatla
pushed a commit
to bhiravabhatla/jaeger
that referenced
this pull request
Jan 25, 2021
…SCRAM-SHA-512 mechanism (jaegertracing#2724) * add that suppot Kafka SASL/PLAIN authentication of SCRAM-SHA-256 or SCRAM-SHA-512 mechanism Signed-off-by: WalkerWang731 <[email protected]> * rename XDGSCRAMClient to scramClient and remove paramater that no point on factory_test.go Signed-off-by: WalkerWang731 <[email protected]> * add type assertion Signed-off-by: WalkerWang731 <[email protected]> * replacement UserName to Username Signed-off-by: WalkerWang731 <[email protected]>
This was referenced Jan 11, 2022
|
@WalkerWang731 and all others: Thanks a lot for all about SCRAM. Linked to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
pkg/kafka/auth/plaintext.go,pkg/kafka/auth/options.goandpkg/kafka/auth/config.go, and not add any new file.mechanism(reference from Kafka parameter name rules )plaintextbetter thanscarm, because these are both belong toSASL, in the future, it can change tosaslif needed. Actually, usingplaintextis ok, it will not be confusing, because it name isSASL_PLAINTEXTthat from Kafka official security protocol parameter namemechanism, I followed Kafka name rules (SCRAM-SHA-256,SCRAM-SHA-512,PLAIN)plaintextmechanism, and add to default. If users do not specify the mechanism, it not affect continued use. if users use the mechanism then just only add--kafka.ROLE.plaintext.mechanismparameter then can use it.Changelog
Add that support Kafka SASL/PLAIN authentication of SCRAM-SHA-256 or SCRAM-SHA-512 mechanism
Parameter config of collector (
SPAN_STORAGE_TYPE=kafka)Parameter config of ingester