plaintext as supported kafka auth option #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre De Paepe <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 95.73% 95.75% +0.02%
==========================================
Files 216 216
Lines 9599 9599
==========================================
+ Hits 9190 9192 +2
+ Misses 336 335 -1
+ Partials 73 72 -1
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Jan 11, 2021
bhiravabhatla
pushed a commit
to bhiravabhatla/jaeger
that referenced
this pull request
Jan 25, 2021
…ing#2721) Signed-off-by: Pierre De Paepe <[email protected]> Co-authored-by: Pierre De Paepe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Jaeger Team,
This tiny patch will simply add "plaintext" as one of the supported Kafka authentication in the CLI options.
Thanks for your awesome work on this project.
Signed-off-by: Pierre De Paepe [email protected]