Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with all-in-one build #2670

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix issue with all-in-one build #2670

merged 1 commit into from
Nov 30, 2020

Conversation

Ashmita152
Copy link
Contributor

@Ashmita152 Ashmita152 commented Nov 30, 2020

Signed-off-by: Ashmita Bohara [email protected]

Which problem is this PR solving?

Fix #2669 (comment)

/cc @yurishkuro

Signed-off-by: Ashmita Bohara <[email protected]>
@Ashmita152 Ashmita152 requested a review from a team as a code owner November 30, 2020 07:42
@mergify mergify bot requested a review from jpkrohling November 30, 2020 07:42
@Ashmita152
Copy link
Contributor Author

Hopefully this will be the last one 🤞

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #2670 (ce3b180) into master (38e75ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2670   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files         213      213           
  Lines        9491     9491           
=======================================
  Hits         9026     9026           
  Misses        388      388           
  Partials       77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e75ae...ce3b180. Read the comment docs.

@yurishkuro yurishkuro merged commit adfdd6a into jaegertracing:master Nov 30, 2020
@Ashmita152 Ashmita152 deleted the fix-all-in-one-build-again-again-again branch November 30, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants