-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[anonymizer] Save trace in UI format #2629
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Spans: spans, | ||
Processes: make(map[uimodel.ProcessID]uimodel.Process), | ||
} | ||
for i := range spans { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Process section is not exactly correct because it does not dedupe them, but I don't think it affects the UI.
@Ashmita152 this will likely fail the CI because of testing coverage, would you be interested to complete it? |
Hello @yurishkuro Thank you so much for the implementation. Yes, I am interested to add the unit tests for them. |
Signed-off-by: Yuri Shkuro <[email protected]>
@Ashmita152 sounds great, feel free to base another PR on top of these changes. Tip: using GH command line util is the easiest way to pull PRs locally. |
Codecov Report
@@ Coverage Diff @@
## master #2629 +/- ##
==========================================
+ Coverage 95.06% 95.08% +0.01%
==========================================
Files 210 213 +3
Lines 9410 9492 +82
==========================================
+ Hits 8946 9025 +79
- Misses 387 390 +3
Partials 77 77
Continue to review full report at Codecov.
|
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
…ge above 95% Signed-off-by: Ashmita Bohara <[email protected]>
Hi @yurishkuro I have opened this https://github.com/yurishkuro/jaeger/pull/2/files adding test cases. I made sure that the test coverage for uiconv package is above 95%. Regards. |
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
@Ashmita152 thanks! Looks like the overall PR is still under 95% (your PRs would be counted differently). |
Hi @yurishkuro thank you for merging it, let me look into areas where I can improve the code coverage further. |
Signed-off-by: Ashmita Bohara <[email protected]>
Hi @yurishkuro Hopefully this PR yurishkuro#3 will help us cross 95% |
Signed-off-by: Ashmita Bohara <[email protected]>
Improve code coverage for uiconv package
@Ashmita152 ^^^ 🎉 🎉 🎉 |
@Ashmita152 thanks for your help! One last thing that would be good to do is to add some documentation to the docs website describing the new utility and how to use it (including loading into the UI). That same documentation could also turn into a blog post. In fact, it might be sufficient just to mention the utility in the docs website and point to the blog post for example on how to use it. |
Thank you @yurishkuro It was my pleasure. Sure I will work on documentation and blog-post next. |
* Bump opentelemetry-collector to v0.14.0 (jaegertracing#2617) * bump opentelemetry-collector to v0.14.0 Signed-off-by: Pavel Kositsyn <[email protected]> * initialize traceid and spanid explicitly Signed-off-by: Pavel Kositsyn <[email protected]> * fix comments and empty parent span check Signed-off-by: Pavel Kositsyn <[email protected]> * fasten convert traceID/spanID Signed-off-by: Pavel Kositsyn <[email protected]> * fix convertTraceID + fix tests Signed-off-by: Pavel Kositsyn <[email protected]> * Update CodeQL to latest best practices (jaegertracing#2615) This will parallelize your analysis and speed things up a bunch. Signed-off-by: jhutchings1 <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> * Fix flaky TestReload (jaegertracing#2624) Signed-off-by: albertteoh <[email protected]> * Update x/text to v0.3.4 (jaegertracing#2625) Signed-off-by: Gary Brown <[email protected]> * Bump to latest UI for snapshot builds (jaegertracing#2626) Signed-off-by: Yuri Shkuro <[email protected]> * Implement anonymizer's main program (jaegertracing#2621) * Preparing release 1.21.0 (jaegertracing#2630) * updated changelog Signed-off-by: Joe Elliott <[email protected]> * Added ui changelog Signed-off-by: Joe Elliott <[email protected]> * Fixed UI changelog to point to 1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Updated jaeger-ui to v1.12.0 Signed-off-by: Joe Elliott <[email protected]> * Resolving concerns Signed-off-by: Joe Elliott <[email protected]> * [anonymizer] Save trace in UI format (jaegertracing#2629) * Use fossa-contrib/fossa-action instead (jaegertracing#2571) * Use fossa-contrib/fossa-action instead Signed-off-by: Sora Morimoto <[email protected]> * Make step name clearer Signed-off-by: Sora Morimoto <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> * Update Makefile and Dockerfile for anonymizer (jaegertracing#2632) Signed-off-by: Ashmita Bohara <[email protected]> * Fix listen IP in unit test (jaegertracing#2636) Signed-off-by: zouyu <[email protected]> * Bump opentelemetry to v0.15.0 (jaegertracing#2634) * Bump opentelemetry to v0.15.0 Signed-off-by: Pavel Kositsyn <[email protected]> * add default value instead of nil value for jaegerreceiver config Signed-off-by: Pavel Kositsyn <[email protected]> * make lint Signed-off-by: Pavel Kositsyn <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]> Co-authored-by: Justin Hutchings <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Albert <[email protected]> Co-authored-by: Gary Brown <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Ashmita <[email protected]> Co-authored-by: Joe Elliott <[email protected]> Co-authored-by: Sora Morimoto <[email protected]> Co-authored-by: ZouYu <[email protected]> Co-authored-by: Kositsyn Pavel <[email protected]>
Resolves #2556
cc @Ashmita152