Avoid deadlock if Stop is called before Serve #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a tiny state machine to detect the transition init -> stopped (not via serving) Fixes jaegertracing#2601 Related jaegertracing#103 Signed-off-by: Carl Henrik Lunde <[email protected]>
yurishkuro
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
nice!
I restarted CI because it failed on another flaky test (certWatcher, #2586)
Codecov Report
@@ Coverage Diff @@
## master #2608 +/- ##
==========================================
+ Coverage 95.07% 95.10% +0.02%
==========================================
Files 209 209
Lines 9366 9370 +4
==========================================
+ Hits 8905 8911 +6
+ Misses 385 384 -1
+ Partials 76 75 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a tiny state machine to detect the transition init -> stopped (not via serving)
Not 100% sure about this, I don't now this code and the origin issue mentions an issue
thrift_processortoo, but that might have been fixed already?Fixes #2601
Related #103