Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ES OTEL status code #2501

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay [email protected]

Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay requested a review from a team as a code owner September 22, 2020 09:08
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merge on green.

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #2501 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2501      +/-   ##
==========================================
+ Coverage   95.20%   95.21%   +0.01%     
==========================================
  Files         208      208              
  Lines        9158     9158              
==========================================
+ Hits         8719     8720       +1     
+ Misses        364      363       -1     
  Partials       75       75              
Impacted Files Coverage Δ
plugin/storage/integration/integration.go 77.90% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9039481...c81a334. Read the comment docs.

@pavolloffay pavolloffay merged commit 2e1b869 into jaegertracing:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants