Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up Badger's trace-not-found check #2481

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 16, 2020

Minor clean-up of #2478.

@yurishkuro yurishkuro requested a review from a team as a code owner September 16, 2020 16:54
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro changed the title Correct not found check Clean-up Badger's trace-not-found check Sep 16, 2020
@yurishkuro
Copy link
Member Author

cc @jpkrohling

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #2481 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2481      +/-   ##
==========================================
+ Coverage   95.50%   95.52%   +0.01%     
==========================================
  Files         208      208              
  Lines       10756    10758       +2     
==========================================
+ Hits        10273    10277       +4     
+ Misses        407      405       -2     
  Partials       76       76              
Impacted Files Coverage Δ
plugin/storage/badger/spanstore/reader.go 96.49% <66.66%> (-0.30%) ⬇️
plugin/storage/integration/integration.go 81.39% <0.00%> (+0.46%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37eaced...5c2d01f. Read the comment docs.

@yurishkuro yurishkuro merged commit 0c3eb68 into jaegertracing:master Sep 16, 2020
@yurishkuro yurishkuro deleted the add-not-found-check branch September 16, 2020 17:45
IvanBodnya pushed a commit to IvanBodnya/jaeger that referenced this pull request Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant