Serve jquery-3.1.1.min.js locally #2378
Conversation
| @@ -3,7 +3,7 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0"> | |||
| <head> | |||
| <title>HotROD - Rides On Demand</title> | |||
| <script src="https://code.jquery.com/jquery-3.1.1.min.js"></script> | |||
| <script src="./jquery-3.1.1.min.js"></script> | |||
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous"> | |||
| <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js" integrity="sha384-Tc5IQib027qvyjSMfHjOMaLkfuWVxZxUPnCJA7l2mCWNIpG9mGCD8wGNIcPD7Txa" crossorigin="anonymous"></script> | |||
There was a problem hiding this comment.
what about the Bootstrap CSS and JS? Wouldn't they present similar issues?
There was a problem hiding this comment.
I have tested for load two bootstrap files locally; It will have some impact on the page display; moreover, this address can be accessed in China, so I don't think it is necessary to modify the loading of these two files.
|
please make sure your commits are signed |
I just signed it, do I need restart workflow test? |
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
=======================================
Coverage 95.60% 95.61%
=======================================
Files 206 206
Lines 10548 10548
=======================================
+ Hits 10084 10085 +1
+ Misses 396 394 -2
- Partials 68 69 +1
Continue to review full report at Codecov.
|
|
You can see the DCO check that does not pass. Your signing email must match your GitHub account's email (and possibly name). |
Signed-off-by: Leigg <[email protected]>
|
DCO passed. |
|
I don't know why ci failed, is it related to my modification? |
|
Could you help me find out why I failed in the test? |
yurishkuro
changed the title
|
Thanks! |
The version included in #2378 was somehow different from what's available via https://code.jquery.com/jquery-3.1.1.min.js Signed-off-by: Yuri Shkuro <[email protected]>
Which problem is this PR solving?
Short description of the changes
If some Country or Area cannot access
https://code.jquery.com/jquery-3.1.1.min.js, e.g. China; the examplehotrodis also cannot be running normally, please see my problem desc from #2375 .Solving
jquery-3.1.1.min.jsfrom https://code.jquery.com/jquery-3.1.1.min.jsexamples\hotrod\services\frontend\web_assets\jquery-3.1.1.min.js./jquery-3.1.1.min.jsfromhttps://code.jquery.com/jquery-3.1.1.min.jsin html fileexamples\hotrod\services\frontend\web_assets\index.htmlexamples\hotrod\services\frontend\gen_assets.goTesting
The major change is a html file and a auto-generated go file; There are no changes to go files that involve important logic in this PR; So no new unit-test code, but I've tested it locally.