Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gRPC instead of tchannel in hotrod #2307

Merged

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Jun 25, 2020

Related to #2036
Related to #2129

This PR removes the dependency on tchannel-go from hotrod and instead uses gRPC. It also introduces https://github.com/opentracing-contrib/go-grpc dependency to trace the calls.

The number of reported spans is the same as before.

Screenshot of Jaeger UI

@pavolloffay pavolloffay requested a review from a team as a code owner June 25, 2020 12:00
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #2307 into master will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2307      +/-   ##
==========================================
- Coverage   96.23%   96.21%   -0.02%     
==========================================
  Files         218      218              
  Lines       10692    10704      +12     
==========================================
+ Hits        10289    10299      +10     
- Misses        347      350       +3     
+ Partials       56       55       -1     
Impacted Files Coverage Δ
cmd/query/app/server.go 93.18% <88.23%> (-1.63%) ⬇️
cmd/query/app/flags.go 100.00% <100.00%> (ø)
plugin/storage/badger/spanstore/reader.go 96.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f70cab...ef93956. Read the comment docs.

@objectiser
Copy link
Contributor

@pavolloffay Is it possible to add a TLS testcase to improve the coverage?

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would be good if the test coverage could be improved.

@pavolloffay
Copy link
Member Author

The test coverage seems odd.

None of the following files are changed in this PR:


cmd/query/app/server.go | 93.18% <88.23%> (-1.63%) |  
-- | -- | --
cmd/query/app/flags.go | 100.00% <100.00%> (ø) |  
plugin/storage/badger/spanstore/reader.go

Anyways there are not tests in hotrod.

@pavolloffay pavolloffay merged commit 6dfb50d into jaegertracing:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants