-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not keep old key versions on disk in Badger #2150
Do not keep old key versions on disk in Badger #2150
Conversation
@mschneider82 could you please sign off the PR? (DCO check) |
Codecov Report
@@ Coverage Diff @@
## master #2150 +/- ##
==========================================
+ Coverage 96.14% 96.16% +0.01%
==========================================
Files 219 219
Lines 10585 10586 +1
==========================================
+ Hits 10177 10180 +3
+ Misses 353 351 -2
Partials 55 55
Continue to review full report at Codecov.
|
Signed-off-by: Matthias Schneider <[email protected]>
2923a3d
to
2a31ad7
Compare
@burmanm Any concerns with this change? |
It's not really doing what I think the author thinks it's doing: ```// This is important. Without this Badger would keep atleast 1 version of very key.`` In reality, So if this helps with cleaning, it sounds like a bug in the badger rather than correct configuration option. |
in dgraph-io/badger#1228 they recommend to set it to 0 to solve the issue, but that issue is still open, lets see how the default may change. I think instant drop is what we want for jaeger, so |
Looks nice to me. |
FYI, according to this closed PR (dgraph-io/badger#1300), changing this to 0 might have unintended effects on valid entries (dgraph-io/badger#1300 (comment)). |
Hey! Please do not set |
Which problem is this PR solving?
Resolves #1916
Short description of the changes
set NumVersionsToKeep to 0 instead of default 1 acording to dgraph-io/badger#1228