Clock skew config

[joe-elliott]

Which problem is this PR solving?

• Fixes Restrict clock skew adjustment to a certain max delta #2053

Short description of the changes

• Added duration parameter query.max-clock-skew-adjust
• Wiring to pass into adjusters.ClockSkew()
• Tests to confirm functionality

Note that I consolidated the creation of QueryServiceOptions in the cmd/query/app package. I don't necessarily think this is a great place for it, but I struggled to find a better one. If you have recommendations please let me know.

[codecov]

Codecov Report

Merging #2119 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2119      +/-   ##
==========================================
+ Coverage    96.1%   96.13%   +0.02%     
==========================================
  Files         217      218       +1     
  Lines       10538    10564      +26     
==========================================
+ Hits        10128    10156      +28     
+ Misses        354      353       -1     
+ Partials       56       55       -1

Impacted Files	Coverage Δ
cmd/query/app/util.go	100% <ø> (ø)	⬆️
cmd/query/app/flags.go	100% <100%> (ø)	⬆️
cmd/query/app/querysvc/adjusters.go	100% <100%> (ø)
model/adjuster/clockskew.go	100% <100%> (ø)	⬆️
cmd/query/app/querysvc/query_service.go	100% <100%> (ø)	⬆️
cmd/query/app/server.go	94.52% <0%> (+2.73%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602cdf4...a6f1969. Read the comment docs.

[yurishkuro]

one small nit, since it affects public api

[yurishkuro]

Can we get code coverage up?

[joe-elliott]

Test pushed that should raise coverage. It's a bit trivial as it just asserts nil and non-nil fields on the QueryServiceOptions struct after building.