[ES, C*] Check for the presence of a tag #2054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2054 +/- ##
==========================================
- Coverage 97.39% 97.26% -0.14%
==========================================
Files 207 207
Lines 10286 10330 +44
==========================================
+ Hits 10018 10047 +29
- Misses 223 238 +15
Partials 45 45
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Feb 3, 2020
| @@ -301,9 +308,30 @@ func (s *SpanReader) findTraceIDs(ctx context.Context, traceQuery *spanstore.Tra | |||
| if len(traceQuery.Tags) > 0 { | |||
| return s.queryByTagsAndLogs(ctx, traceQuery) | |||
| } | |||
| if len(traceQuery.CheckTagsPresent) > 0 { | |||
| s.queryCheckTagPresence(ctx, traceQuery) | |||
|
I'd like to wait for #2049 to be merged before moving forward with this. |
|
@annanay25 looks like #2049 is already there ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
In the UI, this feature could be implemented as a search-box, input being a comma separated list of tags that need to be present in the result traces.