Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that operation_name table can not be init more than once #1961

Merged

Conversation

guo0693
Copy link
Contributor

@guo0693 guo0693 commented Dec 3, 2019

Signed-off-by: Jun Guo [email protected]

Which problem is this PR solving?

  • If we materialize the operation_names schema more than once, the original query template will be changed to something like
    INSERT INTO operation_names_v2(service_name, span_kind, operation_name) VALUES (?, ?, ?)%!!(string=operation_names_v2)(EXTRA string=operation_names_v2)

Short description of the changes

  • Do not use pointer for schemas map. Always materialize the copied struct for the storage use

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #1961 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1961      +/-   ##
==========================================
- Coverage   98.48%   98.46%   -0.03%     
==========================================
  Files         199      199              
  Lines        9875     9875              
==========================================
- Hits         9725     9723       -2     
- Misses        115      116       +1     
- Partials       35       36       +1
Impacted Files Coverage Δ
...gin/storage/cassandra/spanstore/operation_names.go 97.59% <ø> (ø) ⬆️
cmd/query/app/static_handler.go 86.84% <0%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b97b3...631f7b4. Read the comment docs.

@yurishkuro yurishkuro merged commit 85b2d2a into jaegertracing:master Dec 3, 2019
@guo0693 guo0693 deleted the fix-operation-materialization branch December 3, 2019 20:36
@pavolloffay pavolloffay added this to the Release 1.16 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants