Add new input/output type for get operations & util function to read span kind tag #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guo0693
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
vprithvi
reviewed
Nov 18, 2019
vprithvi
reviewed
Nov 18, 2019
guo0693
changed the title
guo0693
force-pushed
the
#1921-1
branch
3 times, most recently
from
a1ddd30
to
4445bd2
Compare
vprithvi
approved these changes
Nov 19, 2019
…span kind tag Signed-off-by: Jun Guo <[email protected]>
yurishkuro
approved these changes
Nov 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
==========================================
+ Coverage 98.45% 98.46% +<.01%
==========================================
Files 198 198
Lines 9740 9744 +4
==========================================
+ Hits 9590 9594 +4
Misses 114 114
Partials 36 36
Continue to review full report at Codecov.
|
pavolloffay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Guo [email protected]
Which problem is this PR solving?
Short description of the changes
Per #1924 (review), I am going to open a few small PRs to replace #1924