Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cassandra] Allow turning off tags/logs indexing #1915

Merged
merged 9 commits into from
Nov 11, 2019

Conversation

joe-elliott
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Moved all index filtering options under index
  • Added 3 options to drop all tags of a certain type
  • Converted log fields filter into a configurable "drop all" filter
  • Fixed bug where ChainedTagFilter was not calling FilterLogFields correctly
  • Added appropriate tests

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #1915 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
+ Coverage   98.45%   98.45%   +<.01%     
==========================================
  Files         198      198              
  Lines        9706     9740      +34     
==========================================
+ Hits         9556     9590      +34     
  Misses        114      114              
  Partials       36       36
Impacted Files Coverage Δ
...cassandra/spanstore/dbmodel/tag_filter_drop_all.go 100% <100%> (ø)
plugin/storage/cassandra/factory.go 100% <100%> (ø) ⬆️
.../storage/cassandra/spanstore/dbmodel/tag_filter.go 100% <100%> (ø) ⬆️
plugin/storage/cassandra/options.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0313d0d...2946e14. Read the comment docs.

@joe-elliott joe-elliott changed the title Add drop all filters for each tag type [cassandra] Drop filters for tag indexing by type Nov 11, 2019
@joe-elliott
Copy link
Member Author

Manually tested in our environment. Dropping draft status.

@yurishkuro yurishkuro merged commit b6086ec into jaegertracing:master Nov 11, 2019
@yurishkuro yurishkuro changed the title [cassandra] Drop filters for tag indexing by type [cassandra] Allow turning off tags/logs indexing Nov 11, 2019
@pavolloffay pavolloffay added this to the Release 1.16 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling of log indexing
3 participants