Use node 10 when building docker images #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1871 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 197 197
Lines 9645 9645
=======================================
Hits 9495 9495
Misses 114 114
Partials 36 36Continue to review full report at Codecov.
|
|
It should work with 8, but needs a newer patch
Travis is apparently not installing the latest available 8.x |
yurishkuro
approved these changes
Oct 21, 2019
|
I am not sure why it does not install the latest 8 version. 8 will be OEL soon. 10 seems like a good option https://github.com/nodejs/Release |
|
Publishing latest images works now https://travis-ci.org/jaegertracing/jaeger/jobs/601180088 |
radekg
pushed a commit
to Klarrio/jaeger
that referenced
this pull request
Oct 28, 2019
Signed-off-by: Pavol Loffay <[email protected]> Signed-off-by: radekg <[email protected]>
backjo
pushed a commit
to backjo/jaeger
that referenced
this pull request
Dec 19, 2019
Signed-off-by: Pavol Loffay <[email protected]> Signed-off-by: Jonah Back <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing builds on the master branch:
https://travis-ci.org/jaegertracing/jaeger/jobs/599917635#L780
https://travis-ci.org/jaegertracing/jaeger/jobs/598603785#L780
@everett980 could you please review? I am not sure why UI repo is using node 8 https://github.com/jaegertracing/jaeger-ui/blob/master/.travis.yml#L3