Unpin grpc version and use serviceConfig to set the load balancer

[guanw]

Signed-off-by: Jude Wang [email protected]

Which problem is this PR solving?

• Unpin gRPC #1781

Short description of the changes

• This PR aims to unpin grpc and replace deprecated code

[guanw]

I notice there's a new commit detected in git for idl/ and not sure if I should commit it.

[guanw]

@pavolloffay One question regarding the TestSpanReader_multiRead_followUp_query(introduced in #1677 ), after upgrading lock file this test starts to fail where mocks Index method was expecting two string instead of one. Any idea why?

[guanw]

@pavolloffay Actually it feels like TestSpanReader_multiRead_followUp_query is being flaky since the s.timeRangeIndices(s.spanIndexPrefix, startTime.Add(-time.Hour), endTime.Add(time.Hour)) could compute slice with either one entry or two based on the time zone and time.Now(). I think you need to add a second mock.AnythingOfType("string") to .On("Index", ...) mock function.

[pavolloffay]

I notice there's a new commit detected in git for idl/ and not sure if I should commit it.

If it is not related to this change it should be reverted.

[pavolloffay]

@pavolloffay One question regarding the TestSpanReader_multiRead_followUp_query(introduced in #1677 ), after upgrading lock file this test starts to fail where mocks Index method was expecting two string instead of one. Any idea why?

The changes here does not seem to be related to the ES reader. The test is probably flaky. Could oyu please report that in a separate issue?

[yurishkuro]

There is already an issue for that test: #1713

[codecov]

Codecov Report

Merging #1786 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1786      +/-   ##
==========================================
- Coverage   98.27%   98.23%   -0.05%     
==========================================
  Files         195      195              
  Lines        9555     9555              
==========================================
- Hits         9390     9386       -4     
- Misses        131      134       +3     
- Partials       34       35       +1

Impacted Files	Coverage Δ
pkg/discovery/grpcresolver/grpc_resolver.go	98.57% <ø> (ø)	⬆️
cmd/agent/app/reporter/grpc/builder.go	96.55% <100%> (ø)	⬆️
cmd/query/app/static_handler.go	83.33% <0%> (-3.51%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfeb7a...c254c04. Read the comment docs.