Unpin jaeger-client-go and refresh dependencies #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon and
vprithvi
as code owners
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1780 +/- ##
==========================================
- Coverage 98.27% 98.23% -0.05%
==========================================
Files 195 195
Lines 9555 9555
==========================================
- Hits 9390 9386 -4
- Misses 131 134 +3
- Partials 34 35 +1
Continue to review full report at Codecov.
|
yurishkuro
changed the title
yurishkuro
force-pushed
the
unpin-jaeger-client
branch
from
05a8eef
to
4e30acc
Compare
Closed
|
@yurishkuro I think we did discuss the option for doing a major release of the client at the time, as the metric name changes were a breaking change, but there were other changes in the pipeline that also were breaking - so wanted to delay the major version bump. However we needed the new metric names used in the backend, to be consistent with other changes in the backend. |
vprithvi
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@objectiser not sure why jaeger-client was pinned to specific commit in #1282 without a new release, but it seems like everything compiles with the latest release.