Small memory optimizations in badger write-path #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
- Coverage 98.27% 98.23% -0.05%
==========================================
Files 195 195
Lines 9540 9550 +10
==========================================
+ Hits 9375 9381 +6
- Misses 131 134 +3
- Partials 34 35 +1
Continue to review full report at Codecov.
|
pressure. Also, add some benchmarks for easier profiling to improve performance in the future. Signed-off-by: Michael Burman <[email protected]>
burmanm
force-pushed
the
badger_small_opts
branch
from
bd8a1aa
to
1ee8eca
Compare
yurishkuro
approved these changes
Sep 7, 2019
There was a problem hiding this comment.
if there is a significant memory/gc pressure from these allocations, this should certainly help, but an even more efficient solution would be to pool byte arrays (or byte buffers) using sync.Pool. It could be a single pool since the buffers will eventually be extended to fit most of the keys.
bookmoons
pushed a commit
to bookmoons/jaeger
that referenced
this pull request
Sep 10, 2019
…ng#1771) Small memory optimizations in badger write-path pressure. Also, add some benchmarks for easier profiling to improve performance in the future. Signed-off-by: Michael Burman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is work from another unfinished PR ported as standalone. Adds benchmarks for profiling purposes and removes some unnecessary duplicate processing and memory pressure from the write-path mostly.
Improves perf slightly:
But more interesting, reduces memory pressure towards GC when writing:
Short description of the changes
time-package calls are reduced, bytes.Buffer is replaced with writing to slice directly and copy() is used instead of append( ...)