Add the jaeger-mixin for monitoring #1700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
requested review from
black-adder,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
jpkrohling
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1700 +/- ##
=========================================
Coverage ? 98.49%
=========================================
Files ? 193
Lines ? 9291
Branches ? 0
=========================================
Hits ? 9151
Misses ? 111
Partials ? 29Continue to review full report at Codecov.
|
|
I'm closing this in favor of #1668, as I just realized that I could just add my commit to @gouthamve's branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1668 by incorporating the commit from that PR and applying some cleanup as discussed there and during the latest Jaeger bi-weekly meeting, such as removing Cassandra-specific alerts/panels, and using regular Jaeger terminology.
This is just an initial revision. I expect this to be extended by the community with extra dashboards and panels.
cc @gouthamve