Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the threshold precision issue #1665

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Fix the threshold precision issue #1665

merged 1 commit into from
Jul 16, 2019

Conversation

guanw
Copy link
Contributor

@guanw guanw commented Jul 16, 2019

Signed-off-by: Jude Wang [email protected]

Which problem is this PR solving?

Short description of the changes

  • It's potential for conversion from an uint64 traceid to float64 number to lose precision.

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #1665 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
+ Coverage   98.71%   98.71%   +<.01%     
==========================================
  Files         193      193              
  Lines        9240     9243       +3     
==========================================
+ Hits         9121     9124       +3     
  Misses         91       91              
  Partials       28       28
Impacted Files Coverage Δ
storage/spanstore/downsampling_writer.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6891422...6f45467. Read the comment docs.

@yurishkuro yurishkuro merged commit e567725 into jaegertracing:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants