Add tmp-volume to all-in-one image, fixes #1543 #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
burmanm
force-pushed
the
fix_all_in_one_tmp
branch
2 times, most recently
from
c452760
to
87f0d3d
Compare
Signed-off-by: Michael Burman <[email protected]>
pavolloffay
approved these changes
May 29, 2019
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 190 190
Lines 9063 9063
=======================================
Hits 8954 8954
Misses 85 85
Partials 24 24Continue to review full report at Codecov.
|
lukedirtwalker
added a commit
to lukedirtwalker/scion
that referenced
this pull request
Sep 10, 2019
Version 1.12 for me tried to allocate all the ram which would result in the machine no longer reacting. With 1.14 I no longer saw this behavior. Also use the new tmp volume (see jaegertracing/jaeger#1571)
lukedirtwalker
added a commit
to scionproto/scion
that referenced
this pull request
Sep 10, 2019
Version 1.12 for me tried to allocate all the ram which would result in the machine no longer reacting. With 1.14 I no longer saw this behavior. Also use the new tmp volume (see jaegertracing/jaeger#1571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes issue #1543, badger does not start without mounting tmpfs.
Short description of the changes
Adds /tmp volume to the container. This allows the badger storage to work with a simple command:
docker run -e SPAN_STORAGE_TYPE=badgerWhich uses tmpfs in the container in this case. It does not prevent customization to the tmpfs, so user can still issue mount parameters for the tmpfs (such as limiting memory size) by overriding the /tmp mount.