-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag images with commit SHA #1082
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
======================================
Coverage 100% 100%
======================================
Files 140 140
Lines 6622 6622
======================================
Hits 6622 6622 Continue to review full report at Codecov.
|
I'd like to have a separate repo for these so we don't pollute the main repos. |
how do we call it jaeger-foo-stream|build|ci|sha? |
Just for the record I have tried to push ~600 different tags(with different layers) on docker hub. I was still able to access the first tags. |
jaeger-foo-snapshot ? |
sounds good to me, @jpkrohling @objectiser? If not response I will continue with snapshot |
snapshot sounds alright to me. |
@pavolloffay snapshot is fine with me |
Signed-off-by: Pavol Loffay <[email protected]>
b946490
to
b218cd6
Compare
Tag images with commit SHA.
It's necessary if there is an external CI/CD pipeline which is invoked per change in master. @objectiser can provide more info why it is needed.
Some open questions:
https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
Signed-off-by: Pavol Loffay [email protected]