Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag images with commit SHA #1082

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

pavolloffay
Copy link
Member

Tag images with commit SHA.

It's necessary if there is an external CI/CD pipeline which is invoked per change in master. @objectiser can provide more info why it is needed.

Some open questions:

  • should be old SHA tags removed (per number/time)?
  • publish sha tags to a different repo?

https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

Signed-off-by: Pavol Loffay [email protected]

@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #1082 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1082   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         140     140           
  Lines        6622    6622           
======================================
  Hits         6622    6622

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ff822...b218cd6. Read the comment docs.

@black-adder
Copy link
Contributor

I'd like to have a separate repo for these so we don't pollute the main repos.

@pavolloffay
Copy link
Member Author

how do we call it jaeger-foo-stream|build|ci|sha?

@pavolloffay
Copy link
Member Author

Just for the record I have tried to push ~600 different tags(with different layers) on docker hub. I was still able to access the first tags.

@yurishkuro
Copy link
Member

how do we call it jaeger-foo-stream|build|ci|sha?

jaeger-foo-snapshot ?

@pavolloffay
Copy link
Member Author

pavolloffay commented Sep 26, 2018

sounds good to me, @jpkrohling @objectiser? If not response I will continue with snapshot

@jpkrohling
Copy link
Contributor

snapshot sounds alright to me.

@objectiser
Copy link
Contributor

@pavolloffay snapshot is fine with me

Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay merged commit d73db1e into jaegertracing:master Sep 27, 2018
@ghost ghost removed the review label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants