Make the metrics produced by jaeger query scoped to the query compone…

[objectiser]

…nt, and generated for all span readers (not just ES)

Signed-off-by: Gary Brown [email protected]

Which problem is this PR solving?

Two problems:

1. metrics provided by collector, agent and client are all scoped to the component name - the query metrics were not, so the 'query' component has now been added
2. metrics were only being generated when the ES storage was used - the metrics decorator now wraps any span reader impl.

Short description of the changes

Moved use of the span reader decorator to the all-in-one and query mains, so it wraps any span reader impl. Added namespace scope 'query' to be consistent with metrics reported for other components.

[codecov]

Codecov Report

Merging #1074 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1074   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         140     140           
  Lines        6622    6622           
======================================
  Hits         6622    6622

Impacted Files	Coverage Δ
plugin/storage/es/spanstore/reader.go	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d10f2...bb11536. Read the comment docs.

[jpkrohling]

LGTM, but would it be possible to capture a sample of what it was before and how it looks now?

[objectiser]

From jaeger-query using ES storage:

# HELP jaeger_find_traces_attempts jaeger_find_traces_attempts
# TYPE jaeger_find_traces_attempts counter
jaeger_find_traces_attempts 1
# HELP jaeger_find_traces_errLatency jaeger_find_traces_errLatency
# TYPE jaeger_find_traces_errLatency histogram
jaeger_find_traces_errLatency_bucket{le="0.005"} 0
jaeger_find_traces_errLatency_bucket{le="0.01"} 0
jaeger_find_traces_errLatency_bucket{le="0.025"} 0
jaeger_find_traces_errLatency_bucket{le="0.05"} 0
jaeger_find_traces_errLatency_bucket{le="0.1"} 0
jaeger_find_traces_errLatency_bucket{le="0.25"} 0
jaeger_find_traces_errLatency_bucket{le="0.5"} 0
jaeger_find_traces_errLatency_bucket{le="1"} 0
jaeger_find_traces_errLatency_bucket{le="2.5"} 0
jaeger_find_traces_errLatency_bucket{le="5"} 0
jaeger_find_traces_errLatency_bucket{le="10"} 0
jaeger_find_traces_errLatency_bucket{le="+Inf"} 0
jaeger_find_traces_errLatency_sum 0
jaeger_find_traces_errLatency_count 0
# HELP jaeger_find_traces_errors jaeger_find_traces_errors
# TYPE jaeger_find_traces_errors counter
jaeger_find_traces_errors 0

and now, from all-in-one:

# HELP jaeger_query_find_traces_attempts jaeger_query_find_traces_attempts
# TYPE jaeger_query_find_traces_attempts counter
jaeger_query_find_traces_attempts 1
# HELP jaeger_query_find_traces_errLatency jaeger_query_find_traces_errLatency
# TYPE jaeger_query_find_traces_errLatency histogram
jaeger_query_find_traces_errLatency_bucket{le="0.005"} 0
jaeger_query_find_traces_errLatency_bucket{le="0.01"} 0
jaeger_query_find_traces_errLatency_bucket{le="0.025"} 0
jaeger_query_find_traces_errLatency_bucket{le="0.05"} 0
jaeger_query_find_traces_errLatency_bucket{le="0.1"} 0
jaeger_query_find_traces_errLatency_bucket{le="0.25"} 0
jaeger_query_find_traces_errLatency_bucket{le="0.5"} 0
jaeger_query_find_traces_errLatency_bucket{le="1"} 0
jaeger_query_find_traces_errLatency_bucket{le="2.5"} 0
jaeger_query_find_traces_errLatency_bucket{le="5"} 0
jaeger_query_find_traces_errLatency_bucket{le="10"} 0
jaeger_query_find_traces_errLatency_bucket{le="+Inf"} 0
jaeger_query_find_traces_errLatency_sum 0
jaeger_query_find_traces_errLatency_count 0