Make hotrod/docker compose v2 the default #6520
Labels
docker
Pull requests that update Docker code
good first issue
Good for beginners
help wanted
Features that maintainers are willing to accept but do not have cycles to implement
v2
Comments
yurishkuro
added
good first issue
4 tasks
yurishkuro
added a commit
that referenced
this issue
Jan 13, 2025
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Resolves #6520 ## Description of the changes - Rename docker-compose.yml to docker-compose-v1.yml - update reference: script, doc, github actions, makefile ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: zzzk1 <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
ekefan
pushed a commit
to ekefan/jaeger
that referenced
this issue
Jan 14, 2025
…g#6523) <!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Resolves jaegertracing#6520 ## Description of the changes - Rename docker-compose.yml to docker-compose-v1.yml - update reference: script, doc, github actions, makefile ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: zzzk1 <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in examples/hotrod we have two docker compose files, the default one starts jaeger v1 and the one that starts jaeger v2 has non-standard name
docker-compose-v2.yml.We want to swap that so that the default file is for v2 and the v1 file is called
docker-compose-v1.yml.The core of the issue is not just renaming the file, but updating references to that that might exist, like the CI scripts or the READMEs.
For good measure we should do the same with
docker-compose/monitor/docker-compose-v2.ymlThe text was updated successfully, but these errors were encountered: