Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Support CORS headers on OTEL HTTP endpoint #4459

Closed
yurishkuro opened this issue May 23, 2023 · 10 comments · Fixed by #4586
Closed

[Feature]: Support CORS headers on OTEL HTTP endpoint #4459

yurishkuro opened this issue May 23, 2023 · 10 comments · Fixed by #4586
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented May 23, 2023 •
edited
Loading

Requirement

Allow exporting traces from browser directly to Jaeger.

Problem

Access from the browser usually requires addressing the CORS issue.

https://stackoverflow.com/questions/76266837/open-telemetry-cors-issue-exporting-trace-data-to-jaeger

Proposal

Support CORS headers similar to how they are supported on Zipkin endpoint (see #2056). If OTLP HTTP Receiver already supports these, we need to allow configuring them.

Open questions

No response
@yurishkuro yurishkuro added enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels May 23, 2023
@sid-008
Copy link

sid-008 commented May 24, 2023

Hey @yurishkuro, how can I help with this issue?

@yurishkuro
Copy link
Member Author

If you don't know outright how to implement it, you can help by doing research:

  • does OTLP receiver support this? If so, how/where it can be configured.

@sid-008
Copy link

sid-008 commented May 24, 2023 •
edited
Loading

This and this should hopefully help.

Additionally it is mentioned here that CORSSettings can be used to configure a receiver for HTTP CORS. Do let me know if this is satisfactory, and I can try my best to figure this out

@samyakjain10
Copy link

Hi @sid-008, was just wondering if you are still working on this issue

@sid-008
Copy link

sid-008 commented Jun 1, 2023

No I am not, I don't really know how to outright implement it, you can take a shot at it

@sbdtu5498
Copy link

/assign

@sbdtu5498 sbdtu5498 mentioned this issue Jun 6, 2023
Closed
@shubmjagtap
Copy link

Hi @yurishkuro can i work on this ? @sbdtu5498 opened PR but its been 14 days . So can i work on this ?

@yurishkuro
Copy link
Member Author

@shubmjagtap feel free to submit above PR. #4510 is not doing what's needed.

@shubmjagtap
Copy link

yes thanks

@sbdtu5498
Copy link

@yurishkuro didn't get time to catch up on the work again. I have closed the pr for the time being.

@pmuls99 pmuls99 mentioned this issue Jun 23, 2023
Closed
@pmuls99 pmuls99 mentioned this issue Jul 16, 2023
Merged
yurishkuro pushed a commit that referenced this issue Jul 19, 2023
@pmuls99 @severussnape321
Enable CORS settings on OTLP HTTP endpoint (#4586)
013ec4d 
## Which problem is this PR solving?
- Resolves #4459 

## Short description of the changes
- Added a new package corscfg to handle the CORS requests on OTLP HTTP
Endpoint and Zipkin

---------

Signed-off-by: bugslayer-332 <[email protected]>
Co-authored-by: bugslayer-332 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
5 participants
@yurishkuro @samyakjain10 @sbdtu5498 @sid-008 @shubmjagtap