You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is because the grpc/proto response from collector uses nil as the default value for slice, and json.Marshal then encodes nil as null. It is possible that tchannel/thrift didn't follow the same conventions and used empty arrays instead.
…`[]`
- Returning an empty slice for `perOperationStrategies` instead of the default nil slice allows
json.Marshal to marshal it to `[]` instead of `null`
- Fixesjaegertracing#3891
Signed-off-by: Prithvi Raj <[email protected]>
What happened?
Jaeger Agent's sampling endpoint's
perOperationStrategies
field returnsnull
instead of[]
, which breaks older Java jaeger-clients.Steps to reproduce
As of 1.23, sampling endpoint returns the following when using grpc as transport between agent and collector.
Expected behavior
As of version 1.17, sampling endpoint returns the following when using tchannel as transport between agent and collector
This is because the grpc/proto response from collector uses nil as the default value for slice, and json.Marshal then encodes nil as
null
. It is possible that tchannel/thrift didn't follow the same conventions and used empty arrays instead.From https://pkg.go.dev/encoding/json#Marshal,
The text was updated successfully, but these errors were encountered: