Return buffers to pool on network errors or queue overflow (#2609)

Use of sync.Pool requires a .Put for every .Get. On success, the downstream ThriftProcessor invoked .Put via .DataRecd but in error cases there seems to be a leak. Signed-off-by: Carl Henrik Lunde <[email protected]>
jaegertracing · Oct 30, 2020 · be49a63 · be49a63
1 parent ec03a2d
commit be49a63
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/cmd/agent/app/servers/tbuffered_server.go b/cmd/agent/app/servers/tbuffered_server.go
@@ -98,9 +98,11 @@ func (s *TBufferedServer) Serve() {
 				s.metrics.PacketsProcessed.Inc(1)
 				s.updateQueueSize(1)
 			default:
+				s.readBufPool.Put(readBuf)
 				s.metrics.PacketsDropped.Inc(1)
 			}
 		} else {
+			s.readBufPool.Put(readBuf)
 			s.metrics.ReadError.Inc(1)
 		}
 	}