Skip to content

Commit

Permalink
Change New gRPC Max Message Size Option Name
Browse files Browse the repository at this point in the history
Changes new option from `collector.grpc.max-receive-message-length` to
`collector.grpc-server.max-message-size` as suggested during review.

Signed-off-by: Justin Stauffer <[email protected]>
  • Loading branch information
js8080 committed Aug 17, 2021
1 parent ac15861 commit b2f98ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmd/collector/app/builder_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const (
collectorZipkinAllowedHeaders = "collector.zipkin.allowed-headers"
collectorZipkinAllowedOrigins = "collector.zipkin.allowed-origins"
collectorZipkinHTTPHostPort = "collector.zipkin.host-port"
collectorGRPCMaxReceiveMessageLength = "collector.grpc.max-receive-message-length"
collectorGRPCMaxReceiveMessageLength = "collector.grpc-server.max-message-size"
)

var tlsGRPCFlagsConfig = tlscfg.ServerFlagsConfig{
Expand Down
2 changes: 1 addition & 1 deletion cmd/collector/app/builder_flags_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func TestCollectorOptionsWithFlags_CheckMaxReceiveMessageLength(t *testing.T) {
c := &CollectorOptions{}
v, command := config.Viperize(AddFlags)
command.ParseFlags([]string{
"--collector.grpc.max-receive-message-length=8388608",
"--collector.grpc-server.max-message-size=8388608",
})
c.InitFromViper(v)

Expand Down

0 comments on commit b2f98ec

Please sign in to comment.