Improving marshaller testing

Signed-off-by: Geoffrey Beausire <[email protected]>
jaegertracing · Dec 17, 2018 · abf8a9a · abf8a9a
1 parent bcd5ed0
commit abf8a9a
Showing 1 changed file with 19 additions and 0 deletions.
diff --git a/plugin/storage/kafka/marshalling_test.go b/plugin/storage/kafka/marshalling_test.go
@@ -57,3 +57,22 @@ func TestZipkinThriftUnmarshaller(t *testing.T) {
 	_, err := unmarshaller.Unmarshal(bytes)
 	assert.NoError(t, err)
 }
+
+func TestZipkinThriftUnmarshallerErrorNoService(t *testing.T) {
+	bytes := zipkin.ZipkinSerialize([]*zipkincore.Span{
+		{
+			ID: 12345,
+			Name: "foo",
+		},
+	})
+	unmarshaller := NewZipkinThriftUnmarshaller()
+	_, err := unmarshaller.Unmarshal(bytes)
+	assert.Error(t, err)
+}
+
+func TestZipkinThriftUnmarshallerErrorCorrupted(t *testing.T) {
+	bytes := []byte("foo")
+	unmarshaller := NewZipkinThriftUnmarshaller()
+	_, err := unmarshaller.Unmarshal(bytes)
+	assert.Error(t, err)
+}