Skip to content

Commit

Permalink
Making channels for deadlock detector only when it is enabled
Browse files Browse the repository at this point in the history
Signed-off-by: Chodor Marek <[email protected]>
  • Loading branch information
Chodor Marek committed Oct 26, 2018
1 parent f22255d commit 537c557
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions cmd/ingester/app/consumer/deadlock_detector.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,10 @@ func newDeadlockDetector(metricsFactory metrics.Factory, logger *zap.Logger, int
func (s *deadlockDetector) startMonitoringForPartition(partition int32) *partitionDeadlockDetector {
var msgConsumed uint64
w := &partitionDeadlockDetector{
msgConsumed: &msgConsumed,
partition: partition,
closePartition: make(chan struct{}, 1),
done: make(chan struct{}),
logger: s.logger,
closed: false,
msgConsumed: &msgConsumed,
partition: partition,
logger: s.logger,
closed: 0 == s.interval,

incrementAllPartitionMsgCount: func() {
s.allPartitionsDeadlockDetector.incrementMsgCount()
Expand All @@ -98,8 +96,9 @@ func (s *deadlockDetector) startMonitoringForPartition(partition int32) *partiti

if s.interval == 0 {
s.logger.Debug("Partition deadlock detector disabled")
w.closed = true
} else {
w.closePartition = make(chan struct{}, 1)
w.done = make(chan struct{})
go s.monitorForPartition(w, partition)
}

Expand Down Expand Up @@ -141,16 +140,15 @@ func (s *deadlockDetector) start() {
var msgConsumed uint64
detector := &allPartitionsDeadlockDetector{
msgConsumed: &msgConsumed,
done: make(chan struct{}),
logger: s.logger,
closed: false,
closed: 0 == s.interval,
}

if s.interval == 0 {
s.logger.Debug("Global deadlock detector disabled")
detector.closed = true
} else {
s.logger.Debug("Starting global deadlock detector")
detector.done = make(chan struct{})
go func() {
ticker := time.NewTicker(s.interval)
defer ticker.Stop()
Expand Down

0 comments on commit 537c557

Please sign in to comment.