Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder for Jaeger version #650

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

yurishkuro
Copy link
Member

Part of #365, and depends on jaegertracing/jaeger#2547.

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #650 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files         227      227           
  Lines        5906     5906           
  Branches     1484     1484           
=======================================
  Hits         5564     5564           
  Misses        303      303           
  Partials       39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fdec4...b5cea0d. Read the comment docs.

@rubenvp8510
Copy link
Collaborator

This looks good, I'm assuming that we still need to do some work on the query-service side.

@rubenvp8510
Copy link
Collaborator

Nevermind, I saw the PR on the query service side.

@yurishkuro yurishkuro merged commit f952882 into jaegertracing:master Oct 9, 2020
@yurishkuro yurishkuro deleted the jaeger-version branch October 9, 2020 15:22
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants