refactor: convert AccordionLinks to functional component - #3411
Closed
VedantMadane wants to merge 7 commits into
Closed
refactor: convert AccordionLinks to functional component#3411VedantMadane wants to merge 7 commits into
VedantMadane wants to merge 7 commits into
Conversation
VedantMadane
requested review from
mahadzaryab1
and removed request for
a team
January 14, 2026 20:17
jkowall
added
the
changelog:refactoring
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the AccordionLinks component from a class-based PureComponent to a functional component with React.memo for performance optimization.
Changes:
- Converted class-based component to functional component with destructured props
- Replaced
static defaultPropswith default parameter values in function signature - Wrapped export with
React.memoto preservePureComponentbehavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@VedantMadane please sign the DCO and follow those instructions. Thanks! |
Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
VedantMadane
force-pushed
the
refactor-accordionlinks-functional
branch
from
January 15, 2026 04:04
8d5100c to
79f737f
Compare
yurishkuro
reviewed
Jan 19, 2026
yurishkuro
added
the
waiting-for-author
github-actions
Bot
removed
the
waiting-for-author
…Links Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
VedantMadane
force-pushed
the
refactor-accordionlinks-functional
branch
from
January 20, 2026 17:20
67f3f75 to
72b3034
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
…r/SpanDetail/AccordionLinks.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Member
this is not an acceptable way to contribute |
github-actions
Bot
added
the
waiting-for-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Screenshots
Fixes #3364