Add pad_start link formatting function #2505 #2504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2505
Given a traceparent header like 00-00000000000000001b3ef83a5d15ed1b-61409d351b3a5d99-01, jaeger will store (and thus display + interpolate) the trace ID as 1b3ef83a5d15ed1b. When attempting to use the shortened trace ID to link to logs some tracing integrations (in my case, logs using pino instrumented with the OpenTelemetry pino instrumentation) will use the full length trace ID, making jaeger link patterns not work.
This PR adds a
pad_start
formatting function, heavily inspired by javascript's String.padStart to format the trace ID in those cases. If approved, I'll update the documentation in https://github.com/jaegertracing/documentation to mention this function and it's behavior.In addition to this specific function, I'd like feedback on the approach of passing arguments to formatting functions with the space-delimited approach (eg
#{traceID | padStart 32 0}
).How was this change tested?
Unit tests and by running it locally with the following UI config