Release 1.32.0 #1676
Merged
Release 1.32.0 #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 241 241
Lines 7558 7558
Branches 1984 1984
=======================================
Hits 7257 7257
Misses 301 301 ☔ View full report in Codecov by Sentry. |
albertteoh
reviewed
Aug 14, 2023
CHANGELOG.md
Outdated
| - Remove unused bluebird package ([@yurishkuro](https://github.com/yurishkuro) in [#1669](https://github.com/jaegertracing/jaeger-ui/pull/1669)) | ||
| - Migrate ScoreCard.test.js from Enzyme to React Shallow Renderer ([@anshgoyalevil](https://github.com/anshgoyalevil) in [#1653](https://github.com/jaegertracing/jaeger-ui/pull/1653)) | ||
| - Fix the tooltip position of copy value and JSON Buttton ([@anikdhabal](https://github.com/anikdhabal) in [#1650](https://github.com/jaegertracing/jaeger-ui/pull/1650)) | ||
| - Bump @types/object-hash from 3.0.2 to 3.0.3 ([@dependabot](https://github.com/dependabot) in [#1658](https://github.com/jaegertracing/jaeger-ui/pull/1658)) |
There was a problem hiding this comment.
We could probably remove the version bumps. I don't think it provides much value for users, and drowns out the community contributions.
There was a problem hiding this comment.
The 1.31.0 has dependabot PRs in the changelog.
cc) @yurishkuro
There was a problem hiding this comment.
I usually remove dep bumps, I don't think it's a particularly useful info for the changelog. If someone really needs it they can look at git log.
There was a problem hiding this comment.
I have removed it for now. It would be good to be consistent
Signed-off-by: Pavol Loffay <[email protected]>
yurishkuro
approved these changes
Aug 14, 2023
albertteoh
approved these changes
Aug 14, 2023
pavolloffay
added a commit
to jaegertracing/jaeger
that referenced
this pull request
Aug 15, 2023
Blocked by jaegertracing/jaeger-ui#1676 --------- Signed-off-by: Pavol Loffay <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
anshgoyalevil
pushed a commit
to anshgoyalevil/jaeger-ui
that referenced
this pull request
Aug 16, 2023
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves jaegertracing#123 --> ## Description of the changes - ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Pavol Loffay <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Ansh Goyal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test