[trace view] childOf time ordering incorrect gets center aligned

[djeeg]

Description
Intermittently the child spans dont display correctly under the parent
The child spans are there, its just that the placement on the timeline is incorrect
Looks like the child spans get centre aligned

Steps to reproduce the issue:

1. NodeJS
2. Create spans with multiple levels of childOf
3. Use const sampling

Describe the results you received:

I have added the actual start/end time of each span as a tag.
You can see in the attachment, that the 2nd expanded span is supposed to start early than the 1st expanded span

Describe the results you expected:
Child spans started at the correct time

Additional information you deem important (e.g. issue happens only occasionally):

Additional environment details (Browser, etc.):

        sampler: {
            type: 'const',
            param: 1,
        },
        reporter: {
            // logSpans: true,
            flushIntervalMs: 2000
        },

[djeeg]

Update: probably related to clock skew

jaegertracing/jaeger-client-node#122
jaegertracing/jaeger-client-java#192

Could be something related to how the startTime goes from NodeJS to database then back to UI

My diagnositic wrapper for creating a span

    var time1 = Date.now();
    options.startTime = time1;
    const span = getTracer().startSpan(operation_name, options);
    span.setTag(TimeStart, time1);
    span.setTag(TimeStart2, Date.now());

Then I have a JSON dump analysed of span relationship
Parent's Id = 54
Child 1's Id = 0
Child 2's Id = 53
Order of operations is 54 -> 0 -> 53

54-------------------------------------

spanID "3591575c77c8e097"
operationName "operation1"
startTime 15023665------------------------86981000
tags
1
key "time.start"
type "float64"
value 150236659------------4402
2
key "time.start2"
type "float64"
value 150236659----------4402

0--------------------------------------

spanID "46588cf7d1550f63"
operationName "operation2"
references
0
refType "CHILD_OF"
spanID "3591575c77c8e097"
startTime 15023665-------------90162500
tags
1
key "time.start"
type "float64"
value 150236659----------4453
2
key "time.start2"
type "float64"
value 150236659----------4453
3
key "key"
type "string"
value "items:lastupdate"

53-------------------------------------

spanID "df02fd3caf75ced1"
operationName "operation3"
references
0
refType "CHILD_OF"
spanID "3591575c77c8e097"
startTime 15023665----------------------87328500
tags
1
key "time.start"
type "float64"
value 150236659-----------5042
2
key "time.start2"
type "float64"
value 150236659----------------5042

Couple of things:

1. The actual order of operations is 54 -> 0 -> 53, however based upon the startTime the order is incorrectly reported as 54 -> 53 -> 0

2. Looks like I can't override the startTime from code (startTime != time.start)

3. Order based on tagged time.start is correct, 54 -> 0 -> 53

[djeeg]

As suggested, having a process tag of "ip" resolves the issue

Took me a little while to figure out this PR is not yet released
jaegertracing/jaeger-client-node#125

Tempoary workaround

var options = {
    'tags': {
        'version': '0.0.1',
        //todo: [JaegerClientConstants.PROCESS_IP]
        "ip": "127.0.0.1" //todo: DISABLED SKEW - https://github.com/uber/jaeger-ui/issues/50
    }
};
var tracer = JaegerClient.initTracer(config, options);