-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions to dependabot, auto merge on green for dependabot PRs #1376
Add github actions to dependabot, auto merge on green for dependabot PRs #1376
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1376 +/- ##
=======================================
Coverage 86.67% 86.67%
=======================================
Files 89 89
Lines 5006 5006
=======================================
Hits 4339 4339
Misses 513 513
Partials 154 154 Continue to review full report at Codecov.
|
@@ -4,3 +4,8 @@ updates: | |||
directory: "/" | |||
schedule: | |||
interval: daily | |||
|
|||
- package-ecosystem: "github-actions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the quotes here and on the internal
below matter, as they are not used in the above configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, copy/paste from the otel-operator, which likely added each one of them at different times :-)
Restarting the smoke-otel job, failure in the sidecar test. |
The same test failed again. @kevinearls, is this a known issue? |
@jpkrohling not that I am aware of, although I think that test has been a bit flaky in the past. @jkandasa have you seen this? If not we need to investigate. |
@kevinearls These days I do not run |
Looks like #1377 is also failing because of that. So, either master is broken, or the test is really unreliable these days. |
I just ran it locally, and it does indeed fail. Here's what I can see in one of the logs:
This seems to have been recently merged in the main repository. Are we using Reference: jaegertracing/jaeger#2753 |
@jpkrohling Yes, the tests default to using latest |
The current merge queue is then blocked by #1378. |
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
b8217b3
to
ab5fcf4
Compare
Signed-off-by: Juraci Paixão Kröhling [email protected]