Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions to dependabot, auto merge on green for dependabot PRs #1376

Conversation

jpkrohling
Copy link
Contributor

Signed-off-by: Juraci Paixão Kröhling [email protected]

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #1376 (ab5fcf4) into master (b3fd44a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1376   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files          89       89           
  Lines        5006     5006           
=======================================
  Hits         4339     4339           
  Misses        513      513           
  Partials      154      154           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fd44a...ab5fcf4. Read the comment docs.

@@ -4,3 +4,8 @@ updates:
directory: "/"
schedule:
interval: daily

- package-ecosystem: "github-actions"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the quotes here and on the internal below matter, as they are not used in the above configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, copy/paste from the otel-operator, which likely added each one of them at different times :-)

@jpkrohling
Copy link
Contributor Author

Restarting the smoke-otel job, failure in the sidecar test.

@jpkrohling
Copy link
Contributor Author

The same test failed again. @kevinearls, is this a known issue?

@kevinearls
Copy link
Contributor

@jpkrohling not that I am aware of, although I think that test has been a bit flaky in the past. @jkandasa have you seen this? If not we need to investigate.

@jkandasa
Copy link
Member

jkandasa commented Feb 3, 2021

@kevinearls These days I do not run otel tests. But sometimes I see failure on different tests. rerun passes those.

@jpkrohling
Copy link
Contributor Author

Looks like #1377 is also failing because of that. So, either master is broken, or the test is really unreliable these days.

@jpkrohling
Copy link
Contributor Author

jpkrohling commented Feb 3, 2021

I just ran it locally, and it does indeed fail. Here's what I can see in one of the logs:

 $ kubectl logs -n osdk-e2e-6a0aaaed-86e6-417d-b86d-8cda6db5a082 osdk-e2e-6a0aaaed-86e6-417d-b86d-8cda6db5a082-7f777f5c77-btq2t -c jaeger-agent
Error: unknown flag: --jaeger.tags
2021/02/03 11:07:56 Failed to run the service: unknown flag: --jaeger.tags

This seems to have been recently merged in the main repository. Are we using latest images as part of the e2e tests?

Reference: jaegertracing/jaeger#2753

@kevinearls
Copy link
Contributor

@jpkrohling Yes, the tests default to using latest

@jpkrohling
Copy link
Contributor Author

The current merge queue is then blocked by #1378.

@jpkrohling jpkrohling force-pushed the jpkrohling/add-a-github-actions-to-dependabot branch from b8217b3 to ab5fcf4 Compare February 4, 2021 13:47
@jpkrohling jpkrohling merged commit 39d24df into jaegertracing:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants