This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Remove all remaining synchronized implementations of Sampler.sample #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2021 18:14
- Add volatile keyword to underlying samplers so updated references can be made available to other threads. See jaegertracing#609 for similar work. Fixes jaegertracing#807 Signed-off-by: Will Tran <[email protected]>
- Use a ConcurrentHashMap for operationNameToSampler so that any number of concurrent calls to sample can be made and safely modify it. - Add volatile to any fields that can be changed by the update method to ensure visibility of changes to other threads. - Retain instances of GuaranteedThroughputSampler to preserve their rate limit balances across updates when parameters don't change improving on jaegertracing/jaeger#1729 See jaegertracing#609 for similar work. Fixes jaegertracing#807 Signed-off-by: Will Tran <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #807 and improves on jaegertracing/jaeger#1729 by not replacing samplers on every update. Rate limit budgets will only be reset if the operation's lower bound rate limit changes.
Short description of the changes
volatilefields similar to Concurrency improvements to RemoteControlledSampler #609volatilefields and a ConcurrentHashMap instead