This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Add public method isFinished() on JaegerSpan #634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In complicated future/multi-threading environments, such as RX java, you need to pass trace context to the executing threads. In some cases we noticed that spans were activated long after the span has finished (like 30 minutes).
I've noticed hourly repeating tasks used stale trace context. By adding isFinished on the JaegerSpan, we can keep track (via metrics) of spans that are being activated but are themselves finished.
Short description of the changes
Adding public method isFinished to JaegerSpan.