This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
#585 offer manual shutdown of jaeger tracer #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2019 17:13
Do not register a JaegerTracer shutdown hook in Glassfish/Payara as it caused exceptions: It is executed after the container is shutdown and the class loader might not be available anymore. Signed-off-by: Sven Tennie <[email protected]>
When this flag is `true`, no shutdown hook is registered at the JVM. This is useful in environments that do not support this kind of hooks or when the user wants to control the closing of JaegerTracer by oneself. Signed-off-by: Sven Tennie <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
============================================
- Coverage 89.5% 89.27% -0.23%
- Complexity 539 540 +1
============================================
Files 68 68
Lines 1944 1949 +5
Branches 250 251 +1
============================================
Hits 1740 1740
- Misses 130 133 +3
- Partials 74 76 +2
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Feb 13, 2019
jpkrohling
approved these changes
Feb 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?