Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Update reporter success metric on append in RemoteReporter (#211) #572

Merged

Conversation

ikurovsky
Copy link
Contributor

Which problem is this PR solving?

Resolves #211

Short description of the changes

Fix RemoteReporter to update the reporterSuccess metric when append operation triggered flush.

Signed-off-by: Igor Kurovsky [email protected]

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

@pavolloffay @jpkrohling

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crossdock test seems to be failing for some reason.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #572 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #572      +/-   ##
===========================================
+ Coverage     89.49%   89.5%   +0.01%     
  Complexity      539     539              
===========================================
  Files            68      68              
  Lines          1942    1944       +2     
  Branches        249     250       +1     
===========================================
+ Hits           1738    1740       +2     
  Misses          130     130              
  Partials         74      74
Impacted Files Coverage Δ Complexity Δ
...egertracing/internal/reporters/RemoteReporter.java 82.55% <100%> (+0.41%) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07f1ba...1408105. Read the comment docs.

@objectiser objectiser merged commit ff929f6 into jaegertracing:master Dec 6, 2018
@objectiser
Copy link
Contributor

@ikurovsky Thanks!

@ikurovsky ikurovsky deleted the reporter-success-metric-fix branch December 7, 2018 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants