Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix repeated resolving of sender in configuration #555

Merged
merged 3 commits into from
Sep 19, 2018

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay [email protected]

@ghost ghost assigned pavolloffay Sep 18, 2018
@ghost ghost added the review label Sep 18, 2018
Signed-off-by: Pavol Loffay <[email protected]>
@@ -635,8 +635,7 @@ public Sender getSender() {
if (null != sender) {
return sender;
}

return SenderResolver.resolve(this);
return (sender = SenderResolver.resolve(this));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

if sender == null {
    sender = resolve()
}
return sender

Signed-off-by: Pavol Loffay <[email protected]>
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #555 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #555      +/-   ##
============================================
+ Coverage     88.76%   88.81%   +0.04%     
  Complexity      519      519              
============================================
  Files            67       67              
  Lines          1896     1895       -1     
  Branches        243      243              
============================================
  Hits           1683     1683              
- Misses          138      139       +1     
+ Partials         75       73       -2
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/io/jaegertracing/Configuration.java 95.41% <ø> (+0.81%) 42 <0> (ø) ⬇️
...java/io/jaegertracing/zipkin/ZipkinV2Reporter.java 71.42% <0%> (-28.58%) 2% <0%> (-1%)
...ing/internal/samplers/RemoteControlledSampler.java 90.69% <0%> (+1.16%) 18% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a9d10...61f27f7. Read the comment docs.

@pavolloffay pavolloffay merged commit 6ee913a into jaegertracing:master Sep 19, 2018
@ghost ghost removed the review label Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants