Use SenderFactory classloader for ServiceLoader

[dbuchhorn]

use ClassLoader of class SenderFactory to instantiate the ServiceLoader to prevent a ServiceConfigurationError (java.util.ServiceConfigurationError: io.jaegertracing.spi.SenderFactory: Provider io.jaegertracing.thrift.internal.senders.ThriftSenderFactory not a subtype)

Fixes #520

Signed-off-by: Dirk Buchhorn [email protected]

[jpkrohling]

Looks like the failure is on the same line, but different reason:

https://travis-ci.org/jaegertracing/jaeger-client-java/jobs/418205475#L1469

[ant:checkstyle] [ERROR] /home/travis/build/jaegertracing/jaeger-client-java/jaeger-core/src/main/java/io/jaegertracing/internal/senders/SenderResolver.java:55: 'SenderFactory' have incorrect indentation level 6, expected level should be 8. [Indentation]

You should also be able to reproduce the problem by running ./gradlew clean check. Let me know if you have problems running this command.

[dbuchhorn]

The problem was we do the gradle build in the root directory. This build reports only errors from the jaeger-thrift project. After run the build in the jaeger-core project the error was reported. We never used gradle before.

[codecov]

Codecov Report

Merging #523 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #523      +/-   ##
============================================
+ Coverage     88.26%   88.27%   +<.01%     
  Complexity      500      500              
============================================
  Files            65       65              
  Lines          1849     1850       +1     
  Branches        239      239              
============================================
+ Hits           1632     1633       +1     
  Misses          140      140              
  Partials         77       77

Impacted Files	Coverage Δ	Complexity Δ
...jaegertracing/internal/senders/SenderResolver.java	96.77% <100%> (+0.1%)	9 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bd0e0...541681d. Read the comment docs.

[jpkrohling]

We never used gradle before.

I'm glad this PR introduced you to new tools!

[jpkrohling]

Thanks for your contribution. This LGTM!