Fix issue where warning message is generated each time a null referen… #487
Conversation
…ce is passed Signed-off-by: Gary Brown <[email protected]>
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
============================================
+ Coverage 88.2% 88.21% +0.01%
Complexity 498 498
============================================
Files 65 65
Lines 1857 1859 +2
Branches 241 242 +1
============================================
+ Hits 1638 1640 +2
Misses 141 141
Partials 78 78
Continue to review full report at Codecov.
|
Signed-off-by: Gary Brown <[email protected]>
|
@jpkrohling Ok for me to merge once coverage is fixed? |
| .withSampler(new ConstSampler(true)) | ||
| .build(); | ||
|
|
||
| JaegerSpan jaegerSpan = tracer.buildSpan("foo").asChildOf(NoopSpan.INSTANCE.context()).start(); |
There was a problem hiding this comment.
I think it more belongs to span test class
There was a problem hiding this comment.
actually in tracer test class there is testAsChildOfAcceptNull but I think it more belongs here even span builder is in tracer class.
There was a problem hiding this comment.
sorry unclear - do you mean move the test back to the JaegerTracerTest class?
There was a problem hiding this comment.
No it's fine here, there is different test in tracer test class which is similar to this tests. I think that one also belongs here
Signed-off-by: Gary Brown <[email protected]>
Signed-off-by: Gary Brown <[email protected]>
|
@pavolloffay Can this be merged now? |
|
@objectiser done |
|
@pavolloffay thanks |
…ce is passed
Signed-off-by: Gary Brown [email protected]
When a null reference was being added, it was creating a warning message that was intended to detect non-JaegerSpanContext implementations. The message was also misleading as it was referring to the type of the
referenceType(string) parameter rather than thereference.