Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Deprecate B3 codec contructor #440

Merged

Conversation

pavolloffay
Copy link
Member

#438 introduced a builder in B3 codec which results in some inconsistency. The codec can be created via constructor and builder. We should either deprecate constructor or remove builder in favor of additional constructor.

I don't expect a lot of parameters in this codec, maybe url encoding, maybe someting more.

  • Be consistent and use only builder pattern

Signed-off-by: Pavol Loffay [email protected]

* Be consistent and use only builder pattern

Signed-off-by: Pavol Loffay <[email protected]>
@ghost ghost assigned pavolloffay Jun 7, 2018
@ghost ghost added the review label Jun 7, 2018
@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #440 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #440      +/-   ##
============================================
- Coverage      87.8%   87.55%   -0.25%     
+ Complexity      518      517       -1     
============================================
  Files            65       65              
  Lines          2000     2000              
  Branches        263      263              
============================================
- Hits           1756     1751       -5     
- Misses          156      160       +4     
- Partials         88       89       +1
Impacted Files Coverage Δ Complexity Δ
...a/io/jaegertracing/propagation/B3TextMapCodec.java 90.38% <ø> (ø) 20 <0> (ø) ⬇️
...in/java/io/jaegertracing/senders/ThriftSender.java 74.41% <0%> (-4.66%) 10% <0%> (ø)
...ava/io/jaegertracing/reporters/RemoteReporter.java 83.33% <0%> (-2.39%) 7% <0%> (ø)
...aegertracing/samplers/RemoteControlledSampler.java 89.53% <0%> (-1.17%) 17% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d57911...cc220ab. Read the comment docs.

@pavolloffay pavolloffay merged commit 855de70 into jaegertracing:master Jun 7, 2018
@ghost ghost removed the review label Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants