Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Span builder should accept null in asChildOf #243

Merged

Conversation

pavolloffay
Copy link
Member

From OpenTracing javadoc:

* If parent==null, this is a noop.

@codecov-io
Copy link

codecov-io commented Sep 25, 2017

Codecov Report

Merging #243 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #243      +/-   ##
============================================
- Coverage     82.02%   81.97%   -0.05%     
+ Complexity      526      524       -2     
============================================
  Files            87       87              
  Lines          2003     2003              
  Branches        236      237       +1     
============================================
- Hits           1643     1642       -1     
  Misses          262      262              
- Partials         98       99       +1
Impacted Files Coverage Δ Complexity Δ
...ger-core/src/main/java/com/uber/jaeger/Tracer.java 86.4% <100%> (+0.87%) 18 <0> (ø) ⬇️
...jaeger/reporters/protocols/ThriftUdpTransport.java 77.96% <0%> (-5.09%) 14% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d4f0ee...c4b2aa0. Read the comment docs.

@jpkrohling
Copy link
Collaborator

Is there a way to test this ?

@pavolloffay
Copy link
Member Author

@jpkrohling there is always a way to test it ;)

@pavolloffay
Copy link
Member Author

Can somebody merge this please?

@yurishkuro yurishkuro merged commit b4c6ad5 into jaegertracing:master Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants