This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Run RemoteReporter's flush timer in daemon thread. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the flush timer's thread from keeping a process alive after main() has returned.
|
|
yurishkuro
reviewed
Feb 1, 2017
| @@ -59,12 +61,14 @@ public RemoteReporter(final Sender sender, int flushInterval, int maxQueueSize, | |||
| commandQueue = new ArrayBlockingQueue<>(maxQueueSize); | |||
|
|
|||
| // start a thread to append spans | |||
| long serialNumber = nextSerialNumber.getAndIncrement(); | |||
There was a problem hiding this comment.
I am not sure why we need this. In a real application there would be only one thread with each name.
There was a problem hiding this comment.
Seemed like a good idea to ensure thread name uniqueness, but you're right, it's not necessary. This is my first pull request on GitHub: do I make the change in my repo then push, or do you do it here directly?
There was a problem hiding this comment.
yes, you make the change in the same branch as you did and just push that branch, the PR should be automatically updated.
yurishkuro
approved these changes
Feb 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the flush timer's thread from keeping a process alive after main() has returned.